Extend log_softmax stabilization rewrite to graphs with indexing and expand_dims#352
Merged
ricardoV94 merged 2 commits intoJun 29, 2023
Merged
Conversation
ricardoV94
changed the title
log(softmax[idx])
ricardoV94
force-pushed
the
stabilize_log_subtensor_softmax
branch
from
225add5 to
7c54695
Compare
ricardoV94
commented
Jun 20, 2023
ricardoV94
force-pushed
the
stabilize_log_subtensor_softmax
branch
from
7c54695 to
9aa9d06
Compare
ricardoV94
changed the title
log(softmax[idx])
ricardoV94
force-pushed
the
stabilize_log_subtensor_softmax
branch
from
9aa9d06 to
a31e827
Compare
ricardoV94
force-pushed
the
stabilize_log_subtensor_softmax
branch
2 times, most recently
from
e3e2611 to
74c2882
Compare
ricardoV94
force-pushed
the
stabilize_log_subtensor_softmax
branch
from
74c2882 to
29dd1d1
Compare
ricardoV94
changed the title
log_softmax stabilization rewrite to graphs with indexing and expand_dims
ricardoV94
changed the title
log_softmax stabilization rewrite to graphs with indexing and expand_dimslog_softmax stabilization rewrite to graphs with indexing and expand_dims
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the rewrite applicable to cases like the PMF of a Categorical, when probabilities are provided as a softmax and there is an expand_dims or indexing in between the
logandsoftmaxAlso removes the
axiswarning in softmax functions